[DataGridPro] Add doc example for tree data children lazy loading #3657
Conversation
flaviendelangle
added
docs
|
These are the results for the performance tests:
|
Co-authored-by: José Rodolfo Freitas <[email protected]>
There was a problem hiding this comment.
Looks good.
You could add one or two sentences before the demo to say:
- we add a property
descendantCountto rows, to know which group cell can be extended - we override both
<GouppingCell />andhandleRowExpansionChangeto take this new property into account
I should simplify the reading, but I'm not sure it is needed
|
|
||
| const GroupingCellWithLazyLoading = (props) => { |
There was a problem hiding this comment.
This is already a complex component. Could add a comment to say that it is not the main one, and explain briefly what it does. For example
This component override the Grouping cell to show the expand/collapse icon according to the descendantCount property instead of the descendants property
| React.useEffect(() => { | ||
| fakeDataFetcher().then(setRows); | ||
|
|
||
| const handleRowExpansionChange = async (node) => { |
There was a problem hiding this comment.
By curiosity, why putting it in a useEffect instead of a useCallback ?
There was a problem hiding this comment.
This useEffect is only called once to initialize the event listeners and init the top level rows.
Part of #3377
Doc preview